yiguolei commented on code in PR #41602:
URL: https://github.com/apache/doris/pull/41602#discussion_r1793355839
##########
be/src/pipeline/exec/exchange_sink_buffer.cpp:
##########
@@ -166,6 +166,7 @@ Status ExchangeSinkBuffer::add_block(TransmitInfo&&
request) {
RETURN_IF_ERROR(
BeExecVersionManager::check_be_exec_version(request.block->be_exec_version()));
}
+ _parent->memory_used_counter()->update(request.block->ByteSizeLong());
Review Comment:
我们 exchange sink operator：
1. 先只统计非broad cast 方式的内存，统计方式跟现在这个PR的代码一样。
2. channel 内保存的那一个block的内存。 broadcast方式的正好没有。
3. 对于broadcast 方式的内存，可能是通过那个holder，构造和析构函数里计算，或者直接使用holder limiter的那个值。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
