yiguolei commented on code in PR #41602:
URL: https://github.com/apache/doris/pull/41602#discussion_r1793277677


##########
be/src/pipeline/exec/hashjoin_build_sink.cpp:
##########
@@ -569,12 +570,16 @@ Status HashJoinBuildSinkOperatorX::sink(RuntimeState* 
state, vectorized::Block*
                         std::to_string(std::numeric_limits<uint32_t>::max()));
             }
 
-            local_state._mem_tracker->consume(in_block->bytes());
-            COUNTER_UPDATE(local_state._build_blocks_memory_usage, 
in_block->bytes());
-
+            auto old_block_mem_usage = 
local_state._build_side_mutable_block.allocated_bytes();
             SCOPED_TIMER(local_state._build_side_merge_block_timer);
             
RETURN_IF_ERROR(local_state._build_side_mutable_block.merge_ignore_overflow(
                     std::move(*in_block)));
+            auto new_block_mem_usage = 
local_state._build_side_mutable_block.allocated_bytes();
+            local_state._mem_tracker->consume(new_block_mem_usage - 
old_block_mem_usage);
+            
local_state._memory_used_counter->set(local_state._mem_tracker->consumption());
+            local_state._peak_memory_usage_counter->set(
+                    local_state._mem_tracker->peak_consumption());
+            COUNTER_SET(local_state._build_blocks_memory_usage, 
(int64_t)new_block_mem_usage);

Review Comment:
   至少跟580 行一致



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to