jacktengg commented on code in PR #41602:
URL: https://github.com/apache/doris/pull/41602#discussion_r1793251018
##########
be/src/pipeline/exec/aggregation_sink_operator.cpp:
##########
@@ -231,15 +231,16 @@ void
AggSinkLocalState::_update_memusage_with_serialized_key() {
_agg_arena_pool->size() +
Base::_shared_state->aggregate_data_container->memory_usage() -
Base::_shared_state->mem_usage_record.used_in_arena;
- Base::_mem_tracker->consume(arena_memory_usage);
- Base::_mem_tracker->consume(
+ auto hash_table_memory_usage =
data.get_buffer_size_in_bytes() -
-
Base::_shared_state->mem_usage_record.used_in_state);
+
Base::_shared_state->mem_usage_record.used_in_state;
+ Base::_mem_tracker->consume(arena_memory_usage);
Review Comment:
有了`MemoryUsage`和`MemoryUsagePeak`这两个counter，这个`_mem_tracker`感觉可以删掉了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
