eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405576346
##########
be/src/olap/column_predicate.h:
##########
@@ -210,6 +212,11 @@ class ColumnPredicate {
virtual bool can_do_bloom_filter(bool ngram) const { return false; }
+ // Check input type could apply safely.
+ // Note: Currenly ColumnPredicate is not include complex type, so use
PrimitiveType
+ // is simple and intuitive
+ virtual bool can_do_apply_safely(PrimitiveType input_type, bool is_null)
const = 0;
Review Comment:
we need type for comparison， but base impl could not perceive type info，or
trick to implement
##########
be/src/olap/column_predicate.h:
##########
@@ -210,6 +212,11 @@ class ColumnPredicate {
virtual bool can_do_bloom_filter(bool ngram) const { return false; }
+ // Check input type could apply safely.
+ // Note: Currenly ColumnPredicate is not include complex type, so use
PrimitiveType
+ // is simple and intuitive
+ virtual bool can_do_apply_safely(PrimitiveType input_type, bool is_null)
const = 0;
Review Comment:
we need type for comparison， but base impl could not perceive type info，or
trick to implement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
