eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405566200
##########
be/src/olap/schema.cpp:
##########
@@ -130,10 +131,11 @@ vectorized::IColumn::MutablePtr
Schema::get_column_by_field(const Field& field)
return get_data_type_ptr(field)->create_column();
}
-vectorized::IColumn::MutablePtr Schema::get_predicate_column_ptr(const Field&
field,
+vectorized::IColumn::MutablePtr Schema::get_predicate_column_ptr(const
FieldType& type,
+ bool
is_nullable,
Review Comment:
to avoid construct const Field& field, it's hard to build Field from DataType
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
