xiaokang commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405899239
##########
be/src/olap/tablet_schema.cpp:
##########
@@ -1015,9 +1145,15 @@ std::vector<const TabletIndex*>
TabletSchema::get_indexes_for_column(int32_t col
return indexes_for_column;
}
-bool TabletSchema::has_inverted_index(int32_t col_unique_id) const {
+bool TabletSchema::has_inverted_index(const TabletColumn& col) const {
// TODO use more efficient impl
+ int32_t col_unique_id = col.unique_id();
+ const std::string& suffix_path =
+ !col.path_info().empty() ?
escape_for_path_name(col.path_info().get_path()) : "";
for (size_t i = 0; i < _indexes.size(); i++) {
+ if (_indexes[i].get_escaped_index_suffix_path() != suffix_path) {
Review Comment:
can we put the above escape_for_path_name into if branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
