github-actions[bot] commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1390819239
##########
be/src/olap/reader.cpp:
##########
@@ -259,6 +260,16 @@ Status TabletReader::_capture_rs_readers(const
ReaderParams& read_params) {
return Status::OK();
}
+TabletColumn TabletReader::materialize_column(const TabletColumn& orig) {
Review Comment:
warning: method 'materialize_column' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/reader.h:266:
```diff
- TabletColumn materialize_column(const TabletColumn& orig);
+ static TabletColumn materialize_column(const TabletColumn& orig);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
