github-actions[bot] commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1391999017
##########
be/src/olap/rowset/segment_creator.cpp:
##########
@@ -257,7 +418,7 @@ int64_t SegmentFlusher::Writer::max_row_to_add(size_t
row_avg_size_in_bytes) {
return _writer->max_row_to_add(row_avg_size_in_bytes);
}
-Status SegmentCreator::init(const RowsetWriterContext& rowset_writer_context) {
+Status SegmentCreator::init(RowsetWriterContext& rowset_writer_context) {
Review Comment:
warning: method 'init' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/rowset/segment_creator.h:163:
```diff
- Status init(RowsetWriterContext& rowset_writer_context);
+ static Status init(RowsetWriterContext& rowset_writer_context);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
