github-actions[bot] commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1390582169
##########
be/src/pipeline/exec/scan_operator.cpp:
##########
@@ -1248,6 +1279,52 @@ Status ScanLocalState<Derived>::_init_profile() {
return Status::OK();
}
+template <typename Derived>
+void ScanLocalState<Derived>::_filter_and_collect_cast_type_for_variant(
+ const vectorized::VExpr* expr,
+ phmap::flat_hash_map<std::string, std::vector<PrimitiveType>>&
colname_to_cast_types) {
Review Comment:
warning: all parameters should be named in a function
[readability-named-parameter]
```suggestion
phmap::flat_hash_map<std::string, std::vector<PrimitiveType>
/*unused*/>& colname_to_cast_types) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
