gaodayue commented on a change in pull request #2050: segment_v2: Support
bitmap index build
URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r347898217
##########
File path: be/src/olap/rowset/segment_v2/encoding_info.cpp
##########
@@ -50,7 +55,7 @@ struct TypeEncodingTraits<type, PLAIN_ENCODING> {
};
template<FieldType type>
-struct TypeEncodingTraits<type, BINARY_PLAIN_ENCODING> {
+struct TypeEncodingTraits<type, PLAIN_ENCODING, Slice> {
Review comment:
In fact there is no need to use different EncodingTypePB to instantiate
different PageBuilder for different data type. Partial template specification
is used here to create BinaryPlainPageBuilder for type using Slice as CppType.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
