gaodayue commented on a change in pull request #2050: segment_v2: Support
bitmap index build
URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r341052148
##########
File path: be/src/olap/rowset/segment_v2/column_writer.cpp
##########
@@ -175,6 +185,9 @@ Status ColumnWriter::append_nullable(
if (_opts.need_zone_map) {
RETURN_IF_ERROR(_column_zone_map_builder->add(nullptr, 1));
}
+ if (_opts.need_bitmap_index) {
+ _bitmap_index_builder->add_nulls(this_run);
Review comment:
I don't quite understand what do you mean here. Here we're recording rowid
for null, why string is stored twice?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
