gaodayue commented on a change in pull request #2050: segment_v2: Support
bitmap index build
URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r347894233
##########
File path: gensrc/proto/segment_v2.proto
##########
@@ -48,12 +48,12 @@ message MetadataPairPB {
enum EncodingTypePB {
UNKNOWN_ENCODING = 0;
DEFAULT_ENCODING = 1;
- PLAIN_ENCODING = 2; // for non-binary type
+ PLAIN_ENCODING = 2;
PREFIX_ENCODING = 3;
RLE = 4;
DICT_ENCODING = 5;
BIT_SHUFFLE = 6;
- BINARY_PLAIN_ENCODING = 7;
Review comment:
Yes, we could reuse PLAIN_ENCODING for BinaryPlainPage, see
https://github.com/apache/incubator-doris/pull/2050/files#diff-7c9224046521dc23a17299f3b1f4a849R60
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
