kangpinghuang commented on a change in pull request #2050: segment_v2: Support
bitmap index build
URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r341006486
##########
File path: be/src/olap/rowset/segment_v2/encoding_info.cpp
##########
@@ -93,42 +128,53 @@ class EncodingInfoResolver {
EncodingInfoResolver();
~EncodingInfoResolver();
- EncodingTypePB get_default_encoding_type(FieldType type) const {
- auto it = _default_encoding_type_map.find(type);
- if (it != std::end(_default_encoding_type_map)) {
+ EncodingTypePB get_default_encoding(FieldType type, bool
optimize_value_seek) const {
+ auto& encoding_map = optimize_value_seek ? _value_seek_encoding_map :
_default_encoding_type_map;
+ auto it = encoding_map.find(type);
+ if (it != encoding_map.end()) {
return it->second;
}
- return DEFAULT_ENCODING;
+ return UNKNOWN_ENCODING;
}
Status get(FieldType data_type, EncodingTypePB encoding_type, const
EncodingInfo** out);
private:
- template<FieldType type, EncodingTypePB encoding_type>
+ template<FieldType type, EncodingTypePB encoding_type, bool
optimize_value_seek = false>
void _add_map() {
EncodingTraits<type, encoding_type> traits;
std::unique_ptr<EncodingInfo> encoding(new EncodingInfo(traits));
if (_default_encoding_type_map.find(type) ==
std::end(_default_encoding_type_map)) {
_default_encoding_type_map[type] = encoding_type;
}
+ if (optimize_value_seek && _value_seek_encoding_map.find(type) ==
_value_seek_encoding_map.end()) {
+ _value_seek_encoding_map[type] = encoding_type;
+ }
auto key = std::make_pair(type, encoding_type);
_encoding_map.emplace(key, encoding.release());
}
std::unordered_map<FieldType, EncodingTypePB, std::hash<int>>
_default_encoding_type_map;
+ // default encoding for each type which optimizes value seek
+ std::unordered_map<FieldType, EncodingTypePB, std::hash<int>>
_value_seek_encoding_map;
+
std::unordered_map<std::pair<FieldType, EncodingTypePB>,
EncodingInfo*, EncodingMapHash> _encoding_map;
};
EncodingInfoResolver::EncodingInfoResolver() {
_add_map<OLAP_FIELD_TYPE_TINYINT, BIT_SHUFFLE>();
+ _add_map<OLAP_FIELD_TYPE_TINYINT, FOR_ENCODING, true>();
_add_map<OLAP_FIELD_TYPE_TINYINT, PLAIN_ENCODING>();
_add_map<OLAP_FIELD_TYPE_SMALLINT, BIT_SHUFFLE>();
+ _add_map<OLAP_FIELD_TYPE_SMALLINT, FOR_ENCODING, true>();
_add_map<OLAP_FIELD_TYPE_SMALLINT, PLAIN_ENCODING>();
_add_map<OLAP_FIELD_TYPE_INT, BIT_SHUFFLE>();
+ _add_map<OLAP_FIELD_TYPE_INT, FOR_ENCODING, true>();
_add_map<OLAP_FIELD_TYPE_INT, PLAIN_ENCODING>();
_add_map<OLAP_FIELD_TYPE_BIGINT, BIT_SHUFFLE>();
+ _add_map<OLAP_FIELD_TYPE_BIGINT, FOR_ENCODING, true>();
_add_map<OLAP_FIELD_TYPE_BIGINT, PLAIN_ENCODING>();
_add_map<OLAP_FIELD_TYPE_LARGEINT, BIT_SHUFFLE>();
_add_map<OLAP_FIELD_TYPE_LARGEINT, PLAIN_ENCODING>();
Review comment:
Add a item for HLL type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
