kangpinghuang commented on a change in pull request #2050: segment_v2: Support
bitmap index build
URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r340986984
##########
File path: be/src/olap/key_coder.h
##########
@@ -96,6 +107,10 @@ class KeyCoderTraits<field_type,
buf->append((char*)&unsigned_val, sizeof(unsigned_val));
}
+ static void encode_ascending(const void* value, size_t index_size,
std::string* buf) {
+ full_encode_ascending(value, buf);
Review comment:
Is it necessary to add (void)index_size to surpress compile warning?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
