kangpinghuang commented on a change in pull request #2050: segment_v2: Support
bitmap index build
URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r341005644
##########
File path: be/src/olap/rowset/segment_v2/encoding_info.cpp
##########
@@ -81,10 +103,23 @@ struct TypeEncodingTraits<type, DICT_ENCODING> {
}
};
-template<FieldType Type, EncodingTypePB Encoding>
-struct EncodingTraits : TypeEncodingTraits<Type, Encoding> {
- static const FieldType type = Type;
- static const EncodingTypePB encoding = Encoding;
+template<FieldType type, typename CppType>
+struct TypeEncodingTraits<type, FOR_ENCODING, CppType,
Review comment:
can this just use type to get CppType from
CppTypeTraits<field_type>::CppType and delete CppType in template?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
