imay commented on a change in pull request #2050: segment_v2: Support bitmap
index build
URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r340973584
##########
File path: be/src/olap/rowset/segment_v2/binary_plain_page.h
##########
@@ -123,13 +136,26 @@ class BinaryPlainPageBuilder : public PageBuilder {
}
private:
+ Status _get_value_at(void* value, size_t idx) const {
+ if (_offsets.size() == 0) {
+ return Status::NotFound("page is empty");
+ }
+ size_t value_size = (idx < _offsets.size() - 1) ?
+ _offsets[idx + 1] - _offsets[idx] : _last_value_size;
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
