imay commented on a change in pull request #2050: segment_v2: Support bitmap
index build
URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r338623435
##########
File path: be/src/olap/key_coder.h
##########
@@ -41,14 +42,20 @@ class KeyCoder {
template<typename TraitsType>
KeyCoder(TraitsType traits);
+ void full_encode_ascending(const void* value, std::string* buf) const {
Review comment:
It will be better to comment the difference between full_encode_ascending
and encode_ascending
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
