imay commented on a change in pull request #2050: segment_v2: Support bitmap
index build
URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r338637051
##########
File path: gensrc/proto/segment_v2.proto
##########
@@ -161,3 +164,51 @@ message SegmentFooterPB {
optional PagePointerPB short_key_index_page = 9;
}
+message IndexPageFooterPB {
+ required int32 num_entries = 1;
+
+ enum Type {
+ UNKNOWN = 999;
+ LEAF = 0;
+ INTERNAL = 1;
+ };
+ required Type type = 2;
+}
+
+message BTreeMetaPB {
+ required PagePointerPB root_page = 1;
+ // true if we only have one data page, in which case root points to that
page directly
+ required bool is_root_data_page = 2;
+}
+
+message IndexedColumnMetaPB {
+ // FieldType value
+ required int32 data_type = 1;
+ required EncodingTypePB encoding = 2;
+ // total number of values in this column
+ required int64 num_values = 3;
+ // present iff this column has ordinal index
+ optional BTreeMetaPB ordinal_index_meta = 4;
+ // present iff this column contains sorted values and has value index
+ optional BTreeMetaPB value_index_meta = 5;
+ // compression type for data and index page
+ optional CompressionTypePB compression = 6 [default=NO_COMPRESSION];
+ // optional bool is_nullable = 7 [default=false];
+}
+
+message BitmapIndexColumnPB {
+ enum BitmapType {
+ UNKNOWN = 999;
Review comment:
Why not unknow = 0 and ROARING_BITMAP = 1?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
