MaheshGPai commented on code in PR #458:
URL: https://github.com/apache/datasketches-cpp/pull/458#discussion_r2144227263
##########
tdigest/include/tdigest.hpp:
##########
@@ -297,6 +310,28 @@ class tdigest {
static inline void check_split_points(const T* values, uint32_t size);
};
+template<typename T, typename A>
+class tdigest<T, A>::const_iterator {
+public:
+ using iterator_category = std::input_iterator_tag;
+ using value_type = std::pair<const T&, const W>;
+ using difference_type = void;
+ using pointer = const return_value_holder<value_type>;
+ using reference = const value_type;
+
+ const_iterator(const tdigest<T, A> &tdigest_, bool is_end);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]