MaheshGPai commented on code in PR #458:
URL: https://github.com/apache/datasketches-cpp/pull/458#discussion_r2140681598
##########
tdigest/include/tdigest_impl.hpp:
##########
@@ -597,6 +597,24 @@ bool tdigest<T, A>::is_single_value() const {
return get_total_weight() == 1;
}
+template<typename T, typename A>
Review Comment:
Maybe my understanding is wrong. I assumed this change is required to pass
on the allocators to the members.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
