AlexanderSaydakov commented on PR #458: URL: https://github.com/apache/datasketches-cpp/pull/458#issuecomment-2968072733
I am still not sure whether this is the best way to provide compatible serialization. Perhaps a better way would be to have serialize_compat() methods or something like that. Having said that, I don't mind this const iterator over the array of centroids. Arguably, it is similar to other quantile sketches, and should provide a set of "best" points representing the distribution seen by t-digest (best that t-digest can do, presumably). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
