sureshanaparti commented on a change in pull request #3638: UEFI Support on
CloudStack
URL: https://github.com/apache/cloudstack/pull/3638#discussion_r358759269
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
##########
@@ -245,6 +252,22 @@ public Long getDomainId() {
return domainId;
}
+ private ApiConstants.BootType getBootType() {
+
+ if (StringUtils.isNotBlank(bootType)) {
+ try {
+ String type = bootType.trim().toUpperCase();
+ return ApiConstants.BootType.valueOf(type);
+ } catch (IllegalArgumentException e) {
+ String errMesg = "Invalid bootType " + bootType + "Specified
for vm " + getName()
+ + " Valid values are: UEFI,BIOS ";
Review comment:
Use the enum for valid values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
