sureshanaparti commented on a change in pull request #3638: UEFI Support on
CloudStack
URL: https://github.com/apache/cloudstack/pull/3638#discussion_r356206740
##########
File path:
engine/orchestration/src/main/java/org/apache/cloudstack/engine/cloud/entity/api/VirtualMachineEntityImpl.java
##########
@@ -269,4 +270,23 @@ public void disconnectFrom(NetworkEntity netowrk, short
nicId) {
}
+ @Override
+ public void setParamsToEntity(Map<VirtualMachineProfile.Param, Object>
map) {
+ if (this.vmEntityVO != null) {
+ Map<String, String> details = this.vmEntityVO.getDetails();
+
+ if (details == null) {
Review comment:
Better get and validate details when map is not empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
