DaanHoogland commented on a change in pull request #3532: Add new "Add volume"
button, to add volume to VM instance directly
URL: https://github.com/apache/cloudstack/pull/3532#discussion_r312398181
##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -736,8 +717,47 @@ public VolumeVO allocVolume(CreateVolumeCmd cmd) throws
ResourceAllocationExcept
String userSpecifiedName = getVolumeNameFromCommand(cmd);
- return commitVolume(cmd, caller, owner, displayVolume, zoneId,
diskOfferingId, provisioningType, size, minIops, maxIops, parentVolume,
userSpecifiedName,
+ VolumeVO volume= commitVolume(cmd, caller, owner, displayVolume,
zoneId, diskOfferingId, provisioningType, size,
+ minIops,
+ maxIops, parentVolume, userSpecifiedName,
_uuidMgr.generateUuid(Volume.class, cmd.getCustomId()));
+
Review comment:
:) yes of course it is better, however...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
