DaanHoogland commented on a change in pull request #3532: Add new "Add volume"
button, to add volume to VM instance directly
URL: https://github.com/apache/cloudstack/pull/3532#discussion_r310589963
##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -736,8 +717,47 @@ public VolumeVO allocVolume(CreateVolumeCmd cmd) throws
ResourceAllocationExcept
String userSpecifiedName = getVolumeNameFromCommand(cmd);
- return commitVolume(cmd, caller, owner, displayVolume, zoneId,
diskOfferingId, provisioningType, size, minIops, maxIops, parentVolume,
userSpecifiedName,
+ VolumeVO volume= commitVolume(cmd, caller, owner, displayVolume,
zoneId, diskOfferingId, provisioningType, size,
+ minIops,
+ maxIops, parentVolume, userSpecifiedName,
_uuidMgr.generateUuid(Volume.class, cmd.getCustomId()));
+
Review comment:
@kioie can you modularise this code somewhat? as it has moved it is hard to
compare with the old situation and the method is to complex for an overview at
first glance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
