JoaoJandre commented on code in PR #14502:
URL: https://github.com/apache/cloudstack/pull/14502#discussion_r4388937820
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -6363,14 +6363,15 @@ public static String
generateSecretUUIDFromString(String seed) {
* @param snapshotName Name of the snapshot;
* @param volume VolumeObjectTO of the corresponding volume;
* @param conn Libvirt connection;
+ * @param timeout the timeout in milisseconds
* @throws LibvirtException
*/
public void mergeSnapshotIntoBaseFile(Domain vm, String diskLabel, String
baseFilePath, String topFilePath, boolean active, String snapshotName,
VolumeObjectTO volume,
- Connect conn) throws LibvirtException {
+ Connect conn, long timeout) throws LibvirtException {
if
(AgentPropertiesFileHandler.getPropertyValue(AgentProperties.LIBVIRT_EVENTS_ENABLED))
{
mergeSnapshotIntoBaseFileWithEventsAndConfigurableTimeout(vm,
diskLabel, baseFilePath, topFilePath, active, snapshotName, volume, conn);
Review Comment:
@Damans227 I thought about that for some time during implementation. I feel
like changing this would be out of scope for this PR. I believe we can open a
separate PR to retire the agent config and use the command wait param. But for
now I think the config should stay like this to keep the current behavior, and
not surprise users on a minor version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
