JoaoJandre commented on code in PR #14502:
URL: https://github.com/apache/cloudstack/pull/14502#discussion_r4388962447
##########
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/KvmFileBasedStorageVmSnapshotStrategy.java:
##########
@@ -86,6 +86,7 @@ public class KvmFileBasedStorageVmSnapshotStrategy extends
StorageVMSnapshotStra
private static final List<Storage.StoragePoolType>
supportedStoragePoolTypes = List.of(Storage.StoragePoolType.Filesystem,
Storage.StoragePoolType.NetworkFilesystem,
Storage.StoragePoolType.SharedMountPoint);
private static final String KVM_FILE_BASED_STORAGE_SNAPSHOT_NVRAM =
"kvmFileBasedStorageSnapshotNvram";
+ private static final int DEFAULT_MERGE_TIMEOUT = 10800;
Review Comment:
@Damans227 Since we now have the `commands.timeout` setting, I do not see a
reason to add a new setting just for this. Users can use the `commands.timeout`
to change this behavior. And I think 3 hours is a good default that is being
used by other similar processes in ACS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
