JoaoJandre commented on code in PR #14502:
URL: https://github.com/apache/cloudstack/pull/14502#discussion_r4388823124
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java:
##########
@@ -405,6 +406,21 @@ public boolean parseDomainXML(String domXML) {
return false;
}
+ private void parseBackingFiles(Element disk, DiskDef def) {
+ NodeList backingStoreNodeList =
disk.getElementsByTagName("backingStore");
+ List<String> backingStoreList = new ArrayList<>();
+ while (backingStoreNodeList.getLength() > 0) {
+ Element backingStore = (Element)backingStoreNodeList.item(0);
+ String path = getAttrValue("source", "file", backingStore);
+ if (StringUtils.isEmpty(path)) {
+ break;
+ }
+
backingStoreList.add(path.substring(path.lastIndexOf(File.separator))+1);
Review Comment:
Yes it was, good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
