weizhouapache commented on code in PR #14286:
URL: https://github.com/apache/cloudstack/pull/14286#discussion_r4193724896
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -636,6 +636,14 @@ public void doInTransactionWithoutResult(final
TransactionStatus status) {
true, false, false, false, false, null, null,
null, true, null, null, false);
}
+ //#4-2 - default isolated offering with Source nat service and
egress traffic allowed by default
+ if
(_networkOfferingDao.findByUniqueName(NetworkOffering.DefaultIsolatedNetworkOfferingWithSourceNatServiceDefaultEgressAllowed)
== null) {
+ offering =
_configMgr.createNetworkOffering(NetworkOffering.DefaultIsolatedNetworkOfferingWithSourceNatServiceDefaultEgressAllowed,
Review Comment:
the current default network offering
```
mysql> select * from network_offerings where id=10\G
*************************** 1. row ***************************
id: 10
name: DefaultIsolatedNetworkOfferingWithSourceNatService
uuid: 33c3aab2-ff97-4924-b517-29eb3a37d454
unique_name: DefaultIsolatedNetworkOfferingWithSourceNatService
display_text: Offering for Isolated networks with Source Nat
service enabled
nw_rate: NULL
mc_rate: NULL
traffic_type: Guest
tags: NULL
system_only: 0
specify_vlan: 0
service_offering_id: NULL
conserve_mode: 1
created: 2026-10-05 13:36:25
removed: NULL
default: 1
availability: Required
dedicated_lb_service: 1
shared_source_nat_service: 0
sort_key: 0
redundant_router_service: 0
state: Enabled
guest_type: Isolated
elastic_ip_service: 0
eip_associate_public_ip: 1
elastic_lb_service: 0
specify_ip_ranges: 0
inline: 0
is_persistent: 0
internal_lb: 0
public_lb: 1
egress_default_policy: 0
concurrent_connections: NULL
keep_alive_enabled: 0
supports_streched_l2: 0
supports_public_access: 0
for_vpc: 0
service_package_id: NULL
supports_vm_autoscaling: 1
network_mode: NULL
routing_mode: NULL
specify_as_number: 0
1 row in set (0.00 sec)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
