weizhouapache commented on code in PR #14286:
URL: https://github.com/apache/cloudstack/pull/14286#discussion_r4193712668
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -636,6 +636,14 @@ public void doInTransactionWithoutResult(final
TransactionStatus status) {
true, false, false, false, false, null, null,
null, true, null, null, false);
}
+ //#4-2 - default isolated offering with Source nat service and
egress traffic allowed by default
+ if
(_networkOfferingDao.findByUniqueName(NetworkOffering.DefaultIsolatedNetworkOfferingWithSourceNatServiceDefaultEgressAllowed)
== null) {
+ offering =
_configMgr.createNetworkOffering(NetworkOffering.DefaultIsolatedNetworkOfferingWithSourceNatServiceDefaultEgressAllowed,
Review Comment:
just tested, the column `supports_vm_autoscaling` is 0, I will fix it
```
mysql> select * from network_offerings where id=31\G
*************************** 1. row ***************************
id: 31
name:
DefaultIsolatedNetworkOfferingWithSourceNatServiceEgressAllowed
uuid: 98b4fe94-f27b-45e6-bec2-dab4b69f4105
unique_name:
DefaultIsolatedNetworkOfferingWithSourceNatServiceEgressAllowed
display_text: Offering for Isolated networks with Source Nat
service enabled and egress traffic allowed by default
nw_rate: NULL
mc_rate: 10
traffic_type: Guest
tags: NULL
system_only: 0
specify_vlan: 0
service_offering_id: NULL
conserve_mode: 1
created: 2026-10-06 09:20:45
removed: NULL
default: 1
availability: Optional
dedicated_lb_service: 0
shared_source_nat_service: 0
sort_key: 0
redundant_router_service: 0
state: Enabled
guest_type: Isolated
elastic_ip_service: 0
eip_associate_public_ip: 0
elastic_lb_service: 0
specify_ip_ranges: 0
inline: 0
is_persistent: 0
internal_lb: 0
public_lb: 1
egress_default_policy: 1
concurrent_connections: NULL
keep_alive_enabled: 1
supports_streched_l2: 0
supports_public_access: 0
for_vpc: 0
service_package_id: NULL
supports_vm_autoscaling: 0
network_mode: NULL
routing_mode: NULL
specify_as_number: 0
1 row in set (0.00 sec)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
