abh1sar commented on code in PR #13180:
URL: https://github.com/apache/cloudstack/pull/13180#discussion_r3258801155


##########
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java:
##########
@@ -970,14 +970,9 @@ private void createCheckedBackup(CreateBackupCmd cmd, 
Account owner, boolean isS
              CheckedReservation backupStorageReservation = new 
CheckedReservation(owner,
                      Resource.ResourceType.backup_storage, backupSize, 
reservationDao, resourceLimitMgr)) {
 
-            ActionEventUtils.onStartedActionEvent(User.UID_SYSTEM, 
vm.getAccountId(),
-                    EventTypes.EVENT_VM_BACKUP_CREATE, "creating backup for VM 
ID:" + vm.getUuid(),
-                    vmId, ApiCommandResourceType.VirtualMachine.toString(),
-                    true, 0);
-

Review Comment:
   Since getApiResourceType and getApiResourceId have now been implemented, the 
Start Action Event is generated by ActionEventInterceptor.
   We don't need to call it explicitly here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to