Copilot commented on code in PR #13180:
URL: https://github.com/apache/cloudstack/pull/13180#discussion_r3263499152
##########
api/src/main/java/org/apache/cloudstack/api/command/user/backup/AssignVirtualMachineToBackupOfferingCmd.java:
##########
@@ -102,6 +103,16 @@ public long getEntityOwnerId() {
return CallContext.current().getCallingAccount().getId();
}
+ @Override
+ public Long getApiResourceId() {
+ return vmId;
+ }
+
+ @Override
+ public ApiCommandResourceType getApiResourceType() {
+ return ApiCommandResourceType.VirtualMachine;
Review Comment:
The PR is marked as fixing #9465, but that issue is about
`importBackupOffering` events appearing on the Backup Offering events view.
This change associates assignment events with `VirtualMachine` resources, while
`ImportBackupOfferingCmd` still does not set a `BackupOffering` resource
id/type, so the claimed #9465 fix remains incomplete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
