weizhouapache commented on code in PR #11573:
URL: https://github.com/apache/cloudstack/pull/11573#discussion_r2321156816


##########
server/src/main/java/org/apache/cloudstack/vm/schedule/VMSchedulerImpl.java:
##########
@@ -190,6 +197,11 @@ public boolean start() {
         final TimerTask schedulerPollTask = new ManagedContextTimerTask() {
             @Override
             protected void runInContext() {
+                ManagementServerHostVO msHost = 
managementServerHostDao.findOneInUpState(new 
Filter(ManagementServerHostVO.class, "id", false, 0L, 1L));

Review Comment:
   @shwstppr 
   yes, sure. 
   actually I considered both and decided to use`findOneInUpState` as it is 
being used in more files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to