rohityadavcloud commented on code in PR #11573:
URL: https://github.com/apache/cloudstack/pull/11573#discussion_r2324134109


##########
server/src/main/java/org/apache/cloudstack/vm/schedule/VMSchedulerImpl.java:
##########
@@ -190,6 +196,11 @@ public boolean start() {
         final TimerTask schedulerPollTask = new ManagedContextTimerTask() {
             @Override
             protected void runInContext() {
+                ManagementServerHostVO msHost = 
managementServerHostDao.findOneInUpStateByLongestRuntime();

Review Comment:
   Should we require a GLOBAL_LOCK ? (I'm commenting here, but I don't know 
what's the best place to put it; generally global lock should wrap code which 
needs to run only at most in one mgmt ...)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to