abh1sar commented on code in PR #11215:
URL: https://github.com/apache/cloudstack/pull/11215#discussion_r2212539686
##########
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##########
@@ -2238,6 +2238,12 @@ private VMTemplateVO
updateTemplateOrIso(BaseUpdateTemplateOrIsoCmd cmd) {
sc.addAnd("state", SearchCriteria.Op.NEQ, State.Expunging);
List<VMInstanceVO> vms = _vmInstanceDao.search(sc, null);
if (vms != null && !vms.isEmpty()) {
+ if (!Boolean.TRUE.equals(cmd.getForceUpdateOsType())) {
Review Comment:
@weizhouapache I can make this change, but the issue will still be there for
the api calls.
Do you foresee this impacting any workflows? My initial thought was it would
be relatively uncommon for users to change the OS type of a template or ISO
after deploying VMs from them, so the risk of breaking existing setups seems
low. Happy to proceed as you recommend. let me know your thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
