weizhouapache commented on code in PR #11215:
URL: https://github.com/apache/cloudstack/pull/11215#discussion_r2212025870
##########
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##########
@@ -2238,6 +2238,12 @@ private VMTemplateVO
updateTemplateOrIso(BaseUpdateTemplateOrIsoCmd cmd) {
sc.addAnd("state", SearchCriteria.Op.NEQ, State.Expunging);
List<VMInstanceVO> vms = _vmInstanceDao.search(sc, null);
if (vms != null && !vms.isEmpty()) {
+ if (!Boolean.TRUE.equals(cmd.getForceUpdateOsType())) {
Review Comment:
for backwards compatibility, I suggest to force update vm os types by
default.
on UI, we can uncheck the checkbox by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
