shwstppr commented on code in PR #9752:
URL: https://github.com/apache/cloudstack/pull/9752#discussion_r2193207562
##########
api/src/main/java/org/apache/cloudstack/api/ApiConstants.java:
##########
@@ -657,7 +675,7 @@ public class ApiConstants {
public static final String NETWORK_DEVICE_PARAMETER_LIST =
"networkdeviceparameterlist";
public static final String ZONE_TOKEN = "zonetoken";
public static final String DHCP_PROVIDER = "dhcpprovider";
- public static final String RESULT = "success";
+ public static final String RESULT = "result";
Review Comment:
Just the constant name has been changed and the value remains same for user
```
⇒ git --no-pager grep ApiConstants.RESULT
main|⚑32
api/src/main/java/org/apache/cloudstack/api/response/CreateConsoleEndpointResponse.java:
@SerializedName(ApiConstants.RESULT)
api/src/main/java/org/apache/cloudstack/api/response/RouterHealthCheckResultResponse.java:
@SerializedName(ApiConstants.RESULT)
api/src/main/java/org/apache/cloudstack/api/response/UnmanageVMInstanceResponse.java:
@SerializedName(ApiConstants.RESULT)
```
Constant was used in 3 classes and all have been updated in
https://github.com/apache/cloudstack/pull/9752/commits/ed2bf1afa109a4faebfc70689968ca54cb4aa270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
