DaanHoogland commented on code in PR #9752:
URL: https://github.com/apache/cloudstack/pull/9752#discussion_r2192103836
##########
api/src/main/java/org/apache/cloudstack/api/response/TemplateResponse.java:
##########
@@ -132,7 +132,6 @@ public class TemplateResponse extends
BaseResponseWithTagInformation implements
@SerializedName(ApiConstants.HYPERVISOR)
@Param(description = "the hypervisor on which the template runs")
private String hypervisor;
-
Review Comment:
why remove this extra eol?
##########
api/src/main/java/org/apache/cloudstack/api/ApiConstants.java:
##########
@@ -657,7 +675,7 @@ public class ApiConstants {
public static final String NETWORK_DEVICE_PARAMETER_LIST =
"networkdeviceparameterlist";
public static final String ZONE_TOKEN = "zonetoken";
public static final String DHCP_PROVIDER = "dhcpprovider";
- public static final String RESULT = "success";
+ public static final String RESULT = "result";
Review Comment:
did you check for possible backwards compatibility issues, changing this
user facing constant?
##########
ui/src/views/iam/CreateRole.vue:
##########
@@ -143,7 +143,7 @@ export default {
},
watch: {
'$route' (to, from) {
- if (to.fullPath !== from.fullPath && !to.fullPath.includes('action/')) {
+ if (to.fullPath !== from.fullPath && !to.fullPath.includes('/action/')) {
Review Comment:
was this a bug? (why be more strict now?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
