weizhouapache commented on code in PR #10038:
URL: https://github.com/apache/cloudstack/pull/10038#discussion_r1869688692
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -2754,7 +2762,9 @@ protected FeaturesDef createFeaturesDef(Map<String,
String> customParams, boolea
FeaturesDef features = new FeaturesDef();
features.addFeatures(PAE);
features.addFeatures(APIC);
- features.addFeatures(ACPI);
+ if (!"s390x".equals(System.getProperty("os.arch"))) {
Review Comment:
may be better to create a method like
```
private boolean isHostS390x() {
return S390X.equals(System.getProperty("os.arch");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
