niyam-choudhari commented on PR #10038:
URL: https://github.com/apache/cloudstack/pull/10038#issuecomment-2528235326

   > @niyamsw `"s390x".equals(System.getProperty("os.arch")` is used in several 
lines, we can replace them.
   > 
   > it checks if the host is s390x, is it same as `isGuestS390x` ? in another 
word, should the host arch and guest arch be s390x ? for example, can x86_64 
vms be deployed on a s390x host ?
   
   This PR is only for introducing support for KVM on s390x host and s390x 
guests. 
   I have refactored the code as suggested and added isHostS390x() function to 
make the code more streamlined. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to