shwstppr commented on code in PR #9840:
URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1828878504
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -2428,7 +2428,7 @@ protected void checkIfZoneIsDeletable(final long zoneId) {
// Check if there are any non-removed hosts in the zone.
- if (!_hostDao.listByDataCenterId(zoneId).isEmpty()) {
+ if (!_hostDao.listEnabledIdsByDataCenterId(zoneId).isEmpty()) {
Review Comment:
Original method listed only Enabled hosts,
https://github.com/apache/cloudstack/blob/main/engine/schema/src/main/java/com/cloud/host/dao/HostDaoImpl.java#L514-L517
Should we list all including disabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
