weizhouapache commented on code in PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1824345632
########## agent/conf/agent.properties: ########## @@ -433,3 +433,9 @@ iscsi.session.cleanup.enabled=false # Implicit host tags managed by agent.properties # host.tags= + +# Timeout(in seconds) for SSL handshake when agent connects to server +#ssl.handshake.timeout= Review Comment: since this line is commented by default, can we add the default value ? if there is no default value, add a line to explain what will happen (unlimited ?) ? ########## agent/conf/agent.properties: ########## @@ -433,3 +433,9 @@ iscsi.session.cleanup.enabled=false # Implicit host tags managed by agent.properties # host.tags= + +# Timeout(in seconds) for SSL handshake when agent connects to server +#ssl.handshake.timeout= + +# Wait(in seconds) during agent reconnections +#backoff.seconds= Review Comment: same here, add default value if exists ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
