sureshanaparti commented on code in PR #9792:
URL: https://github.com/apache/cloudstack/pull/9792#discussion_r1801070734
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -3400,19 +3409,20 @@ public synchronized String attachOrDetachISO(final
Connect conn, final String vm
final String name = isoPath.substring(index + 1);
final KVMStoragePool secondaryPool =
storagePoolManager.getStoragePoolByURI(path);
final KVMPhysicalDisk isoVol = secondaryPool.getPhysicalDisk(name);
+ final DiskDef.DiskType diskType = useBLOCKDiskType(isoVol) ?
DiskDef.DiskType.BLOCK : DiskDef.DiskType.FILE;
Review Comment:
```suggestion
final DiskDef.DiskType diskType = getDiskType(isoVol);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
