sureshanaparti commented on code in PR #9792:
URL: https://github.com/apache/cloudstack/pull/9792#discussion_r1801069877
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -3077,8 +3085,9 @@ public int compare(final DiskTO arg0, final DiskTO arg1) {
final DiskDef disk = new DiskDef();
int devId = volume.getDiskSeq().intValue();
if (volume.getType() == Volume.Type.ISO) {
-
- disk.defISODisk(volPath, devId, isUefiEnabled);
+ final DiskDef.DiskType diskType =
useBLOCKDiskType(physicalDisk) ?
Review Comment:
```suggestion
final DiskDef.DiskType diskType = getDiskType(physicalDisk);
```
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -3077,8 +3085,9 @@ public int compare(final DiskTO arg0, final DiskTO arg1) {
final DiskDef disk = new DiskDef();
int devId = volume.getDiskSeq().intValue();
if (volume.getType() == Volume.Type.ISO) {
-
- disk.defISODisk(volPath, devId, isUefiEnabled);
+ final DiskDef.DiskType diskType =
useBLOCKDiskType(physicalDisk) ?
+ DiskDef.DiskType.BLOCK : DiskDef.DiskType.FILE;
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
