sureshanaparti commented on code in PR #9792:
URL: https://github.com/apache/cloudstack/pull/9792#discussion_r1801071935
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##########
@@ -1112,11 +1112,13 @@ protected synchronized void attachOrDetachISO(final
Connect conn, final String v
storagePool = storagePoolMgr.getStoragePoolByURI(path);
}
final KVMPhysicalDisk isoVol = storagePool.getPhysicalDisk(name);
+ final DiskDef.DiskType isoDiskType =
LibvirtComputingResource.useBLOCKDiskType(isoVol) ?
Review Comment:
```suggestion
final DiskDef.DiskType isoDiskType =
LibvirtComputingResource.getDiskType(isoVol);
```
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##########
@@ -1112,11 +1112,13 @@ protected synchronized void attachOrDetachISO(final
Connect conn, final String v
storagePool = storagePoolMgr.getStoragePoolByURI(path);
}
final KVMPhysicalDisk isoVol = storagePool.getPhysicalDisk(name);
+ final DiskDef.DiskType isoDiskType =
LibvirtComputingResource.useBLOCKDiskType(isoVol) ?
+ DiskDef.DiskType.BLOCK : DiskDef.DiskType.FILE;
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
