[ 
https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764737#comment-17764737
 ] 

Stefan Miklosovic commented on CASSANDRA-14667:
-----------------------------------------------

I am not sure I have ever encountered this "code style" elsewhere. Nothing 
indicates that exclusions are used for readability (1). As I understand that, 
that is used solely and primarily for excluding unwanted dependencies on 
purpose. 

As we are effectively not excluding anything as it is on the classpath anyway, 
maybe just putting a comment that logback-core and logback-classic "shadow" the 
respective dependecies in metrics-logback would be just enough.

https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html

> Upgrade Dropwizard Metrics to 4.x
> ---------------------------------
>
>                 Key: CASSANDRA-14667
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14667
>             Project: Cassandra
>          Issue Type: Task
>          Components: Observability/Metrics
>            Reporter: Stig Rohde Døssing
>            Assignee: Maxim Muzafarov
>            Priority: Normal
>             Fix For: 5.x
>
>         Attachments: signature.asc, signature.asc, signature.asc, 
> signature.asc
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for 
> Java 9 compatibility. It would be good to upgrade the Metrics library as part 
> of the version of Cassandra that adds Java 9 compatibility 
> (https://issues.apache.org/jira/browse/CASSANDRA-9608). 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to