[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475420#comment-17475420
]
Josh McKenzie commented on CASSANDRA-16956:
-------------------------------------------
bq. I would also prefer not to touch 4.0
The two committers reviewing this ticket prefer not to merge it to 4.0. Let's
target trunk only.
bq. it could be argued that not removing it when Windows support was deprecated
is a bug;
Cogent argument for sure - I just personally find the argument towards not
destabilizing 4.0 and not treating removal of dead or unsupported features as a
bug more compelling.
Windows support has always been a touch odd; it primarily consists of .py
conditionals, additive .bat and .ps1 changes, and a sprinkling of hard disables
and bypasses (early open, storing a list of files failed to delete due to
junctions and removing on next start, etc). Unlike other features we've
retroactively flagged experimental or removed due to their fundamental
incompatibility with the direction our architecture is evolving or correctness
guarantees, the Windows code is in the "this probably still works just fine,
there's just nobody maintaining it anymore so we're not formally supporting it,
and you should probably use WSL 2.0 anyway" category.
So for that reason as well I'm not that worried about it living on undocumented
and unsupported in 4.0. It's not really hurting anybody.
> Remove windows-specific classes
> -------------------------------
>
> Key: CASSANDRA-16956
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16956
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Brandon Williams
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.0.x, 4.x
>
> Attachments: signature.asc, signature.asc, signature.asc,
> signature.asc, signature.asc, signature.asc
>
>
> To continue the work CASSANDRA-16171 began, now that Windows support is no
> more there are some source files that can be removed.
> Just doing a naive grep on the source directory I see:
> {noformat}
> src/java/org/apache/cassandra/db/WindowsFailedSnapshotTracker.java
> src/java/org/apache/cassandra/utils/NativeLibraryWindows.java
> src/java/org/apache/cassandra/utils/WindowsTimer.java
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
