[
https://issues.apache.org/jira/browse/CASSANDRA-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992049#comment-12992049
]
Eric Evans commented on CASSANDRA-2041:
---------------------------------------
Looks good for the most part, but I have a couple more nits:
1. Can you make sure this conforms to our style guidelines
(http://wiki.apache.org/cassandra/CodeStyle)? For example, there are a few
places where you're adding extra whitespace to justify variables, and multiline
statements should be aligned on the open parens, with one arg per line.
2. I think you can remove a tiny bit of duplication by changing the signature
of {{serializeColumns(IColumnIterator columns, PrintStream out)}} to
{{serializeColumns(Iterator<IColumn> columns, PrintStream out)}} and either
invoking it from {{serializeColumns(Collection<IColumn> columns, PrintStream
out)}}, (or you could even remove the latter and call the former using
{{columns.iterator()}} where necessary ).
> add paging of large rows to sstable2json
> ----------------------------------------
>
> Key: CASSANDRA-2041
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2041
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.2
>
> Attachments: CASSANDRA-2041-v2.patch, CASSANDRA-2041.patch
>
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
