[
https://issues.apache.org/jira/browse/CASSANDRA-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991585#comment-12991585
]
Eric Evans commented on CASSANDRA-2041:
---------------------------------------
This is difficult to review. At a minimum, there is too much going on for a
single patch, but I also thing there are too many unrelated/unnecessary changes
included.
I assume the meat of the patch is the paging of PAGE_SIZE columns in a row, but
all of the JSON serialization to PrintStreams was replaced with methods that
buffer everything to a StringBuilder. Doesn't this defeat the purpose of the
added paging? Meaning, we used to buffer an entire row in memory before
streaming it out, and now we page through a row in order to buffer the JSON in
memory.
> add paging of large rows to sstable2json
> ----------------------------------------
>
> Key: CASSANDRA-2041
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2041
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.2
>
> Attachments: CASSANDRA-2041.patch
>
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
