claudio4j commented on code in PR #5126:
URL: https://github.com/apache/camel-k/pull/5126#discussion_r1476701427
##########
pkg/apis/camel/v1/maven_types_support.go:
##########
@@ -24,7 +24,11 @@ import (
func (in *MavenArtifact) GetDependencyID() string {
switch {
case in.Version == "":
- return "mvn:" + in.GroupID + ":" + in.ArtifactID
+ if in.Classifier == "" {
+ return "mvn:" + in.GroupID + ":" + in.ArtifactID
+ } else {
+ return "mvn:" + in.GroupID + ":" + in.ArtifactID + ":"
+ in.Type + ":" + in.Classifier
Review Comment:
I clarified the behavior and added more testing.
##########
pkg/apis/camel/v1/maven_types_support.go:
##########
@@ -24,7 +24,11 @@ import (
func (in *MavenArtifact) GetDependencyID() string {
switch {
case in.Version == "":
- return "mvn:" + in.GroupID + ":" + in.ArtifactID
+ if in.Classifier == "" {
+ return "mvn:" + in.GroupID + ":" + in.ArtifactID
+ } else {
+ return "mvn:" + in.GroupID + ":" + in.ArtifactID + ":"
+ in.Type + ":" + in.Classifier
Review Comment:
I clarified the behavior and added more tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
